Skip to content

Fixed typo in combined_arms.py#60

Open
McStevenss wants to merge 1 commit intoFarama-Foundation:mainfrom
McStevenss:fix-typo-combined-arms
Open

Fixed typo in combined_arms.py#60
McStevenss wants to merge 1 commit intoFarama-Foundation:mainfrom
McStevenss:fix-typo-combined-arms

Conversation

@McStevenss
Copy link
Copy Markdown

Fixed a typo in combined arms environment that i found while training.

@atstarke atstarke requested a review from Copilot July 24, 2025 18:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a spelling error in the combined arms environment where "bluemele" was corrected to "bluemelee" in the names list. This is a simple typo correction that ensures consistent naming of the blue melee unit type.

np.maximum(reward_vals, 0).sum(),
]
names = ["redmelee", "redranged", "bluemele", "blueranged"]
names = ["redmelee", "redranged", "bluemelee", "blueranged"]
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on fixing the typo! However, there's still an inconsistency in the spelling. The corrected "bluemelee" should be "bluemelee" to match the pattern of "redmelee", but it appears you may have intended "bluemelee" (with double 'e') when the consistent spelling should be "bluemelee" to match "redmelee".

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is litteraly what ive done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants